Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34289 )
Change subject: soc/intel/cannonlake: Split the "internal PME" wake-up into more detail ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34289/1/src/soc/intel/cannonlake/el... File src/soc/intel/cannonlake/elog.c:
https://review.coreboot.org/c/coreboot/+/34289/1/src/soc/intel/cannonlake/el... PS1, Line 57: struct device *dev
We don't seem to use this parameter inside this function. […]
Leftover from the skylake code (which BTW also does not seem to use the param). Removed.
https://review.coreboot.org/c/coreboot/+/34289/1/src/soc/intel/cannonlake/el... PS1, Line 89: b/136673612
This has no meaning for upstream coreboot since b/ is accessible only to Googlers. […]
Added an explanation of where the offset comes from. Removed reference to buganizer.
https://review.coreboot.org/c/coreboot/+/34289/1/src/soc/intel/cannonlake/el... PS1, Line 114: if (!dev_found) : dev_found = pch_xhci_update_wake_event(&usb_info); :
The whole elog for S0ix is kind of Linux specific :). […]
Per comments in the code and Furquan's comments, no need to change any code here. Also, this is what skylake did.