Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34400 )
Change subject: mb/google/hatch/var/kindred: Implement variant_devtree_update()
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34400/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kindred/variant.c:
https://review.coreboot.org/c/coreboot/+/34400/2/src/mainboard/google/hatch/...
PS2, Line 33: google_chromeec_cbi_get_sku_id
Make it non-static, will show compile error as below. how to fix this error? thanks. […]
Posted comment on your other CL. You are missing a header include.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34400
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ccb4dae54f223881e0ced9e034bf45b994cc6f2
Gerrit-Change-Number: 34400
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 19 Jul 2019 04:08:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Wu
david_wu@quanta.corp-partner.google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment