Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32405 )
Change subject: mb/google/kohaku: Update overridetree.cb ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/#/c/32405/6/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/32405/6/src/mainboard/google/hatch/variants/... PS6, Line 204: nit: can you please move this clean up into the previous CL where sd_card_gpio is being moved out of baseboard devicetree?
https://review.coreboot.org/#/c/32405/6/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/#/c/32405/6/src/mainboard/google/hatch/variants/... PS6, Line 32: } },
https://review.coreboot.org/#/c/32405/6/src/mainboard/google/hatch/variants/... PS6, Line 35: } },
https://review.coreboot.org/#/c/32405/6/src/mainboard/google/hatch/variants/... PS6, Line 41: } },
https://review.coreboot.org/#/c/32405/6/src/mainboard/google/hatch/variants/... PS6, Line 70: GPIO_D21_IRQ GPP_D21_IRQ