Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Rizwan Qureshi, Angel Pons.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48344 )
Change subject: soc/intel/common/block/cpu: Introduce CAR_HAS_L3_PROTECTED_WAYS Kconfig
......................................................................
Patch Set 12:
(1 comment)
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/48344/comment/549d4cec_0e9f2b42
PS12, Line 517: mov %ebx, %ecx /* back up number of ways */
: mov %eax, %ebx /* back up the non-eviction mask*/
Thinking out loud (for a later change): Now that there are `wrmsr` and `rdmsr` calls below, maybe we […]
i agree, i will modify the code to make sure we use edi/esi at first place then rebase all CLs on top of that. SG?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48344
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb5a9ec74c50bda371c30e13aeadbb4326887fd6
Gerrit-Change-Number: 48344
Gerrit-PatchSet: 12
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 07 Jul 2021 20:37:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment