Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50654 )
Change subject: util/bincfg: Clean up Makefile
......................................................................
Patch Set 2:
(1 comment)
File util/bincfg/Makefile:
https://review.coreboot.org/c/coreboot/+/50654/comment/5026074e_be689404
PS1, Line 30: ./bincfg
should these be $(abspath $(TARGET)) or something?
Updating in a follow-on patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50654
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0302f663cbc931325334d0cce93d3b0bf937cc6
Gerrit-Change-Number: 50654
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 05 Apr 2021 17:20:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment