Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38350 )
Change subject: soc/intel/broadwell: Comment conflicting use of _ADR and _HID ......................................................................
Patch Set 1:
(1 comment)
What's the purpose of this change? Just to mark as needing to be addressed for a future IASL toolchain update?
https://review.coreboot.org/c/coreboot/+/38350/1/src/soc/intel/broadwell/acp... File src/soc/intel/broadwell/acpi/serialio.asl:
https://review.coreboot.org/c/coreboot/+/38350/1/src/soc/intel/broadwell/acp... PS1, Line 198: // FIXME: Device object requires either a _HID or _ADR, but not both I don't understand this and all subsequent markings. These devices only have an _HID entry, so there's no issue?