Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41871 )
Change subject: drivers/intel/pmx_mux: Remove redundant declaration
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41871/2/src/soc/intel/tigerlake/pmc...
File src/soc/intel/tigerlake/pmc.c:
https://review.coreboot.org/c/coreboot/+/41871/2/src/soc/intel/tigerlake/pmc...
PS2, Line 129: /* FIXME: Rewrite loop below without this. */
Another case for CB:35456?
You bet! I've been meaning to get around to reviewing that. I'll try to take another look soon, as Duncan pointed out, it would simplify a lot of things like this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41871
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie64b267ac01afa9774105e1ab8a7c18021726ff3
Gerrit-Change-Number: 41871
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Fri, 03 Jul 2020 15:35:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment