Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37178 )
Change subject: soc/amd/common/block/acpimmio: fix ACPIMMIO decode enable function ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37178/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37178/1//COMMIT_MSG@7 PS1, Line 7: soc/amd/common/block/acpimmio: fix the ACPIMMIO decode enable function
*the* can be dropped to make the git commit message summary shorter.
Done
https://review.coreboot.org/c/coreboot/+/37178/1//COMMIT_MSG@9 PS1, Line 9: BKDG's
Nit: BKDGs, however I realize an apostrophe when pluralizing abbreviations is more acceptable.
Done
https://review.coreboot.org/c/coreboot/+/37178/1//COMMIT_MSG@11 PS1, Line 11:
Any user visible bug that is fixed by this (TEST=)?
Binary blobs seem to enable this bit, but for early enablement, for example C bootblock implementations, it may be required. Added this info to commit message.