Attention is currently required from: Felix Singer, Sean Rhodes, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58798 )
Change subject: soc/intel/tigerlake/apci: Only use SCM for ChromeOS
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS5:
Yup - using S3 so disabling it is par for the course. […]
This is probably `_PR3` right? Including the `_PR3` method indicates support for D3cold in the latest ACPI spec. Maybe try removing _PR3? That should indicate that it should turn off in D3hot (what device state does Linux put it in for S3?)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58798
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib947c3c9cd843e54d4664509c15336178c0bc99e
Gerrit-Change-Number: 58798
Gerrit-PatchSet: 9
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Sean Rhodes
admin@starlabs.systems
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 05 Nov 2021 01:31:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
admin@starlabs.systems
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment