Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33300 )
Change subject: [RFC and WIP]Add an option to align FMAP regions ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33300/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33300/1//COMMIT_MSG@15 PS1, Line 15: such configuration presents itself
Should definitely error out, I think. […]
so there are 3 options I see: - have both a base and alignment and have to code fixup the base if it's not aligned (probably bad idea) - have both a base and alignment and error out if base is not aligned but continue if it is (works as a check) - make base and alignment mutually exclusive (probably cleanest)
https://review.coreboot.org/#/c/33300/1//COMMIT_MSG@16 PS1, Line 16: - '~' is used. Is that the 'best' symbol
So this would be written […]
the flags are now places right after the SECTION name, so it looks like SECTION(<flags>)@base size ~alignment at the moment. Do we want to change that? I personally like how it looks in your proposal with the flags as last 'argument'. '/' sounds ok