Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32283 )
Change subject: soc/intel/common/timer: Calculate TSC frequency based on CPUID 0x15
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32283/5/src/arch/x86/include/arch/intel-fami...
File src/arch/x86/include/arch/intel-family.h:
https://review.coreboot.org/#/c/32283/5/src/arch/x86/include/arch/intel-fami...
PS5, Line 17:
It might be good to prefix these all with CPUID_ or CPU_MODEL_ or something to distinguish where these values come from.
But, if you didn't run into any name conflicts maybe it is fine...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32283
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ff4b9159a94e61b7e634bd6095f7cc6d7df87c7
Gerrit-Change-Number: 32283
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Apr 2019 17:16:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment