Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30421 )
Change subject: Makefile.inc: Create a default SMMSTORE region
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/30421/5/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/#/c/30421/5/Makefile.inc@893
PS5, Line 893: FMAP_SMMSTORE_SIZE := 0
No. […]
I was advocating for an image assembly tool doing this and more before I wrote this script, but back then that was the only thing I could get through the design phase.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30421
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b7b75050e0139ea9a0a4f2ad3c0d69a482fb38b
Gerrit-Change-Number: 30421
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 06 Feb 2019 18:06:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment