Attention is currently required from: Nicholas Sudsgaard, Paul Menzel.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84989?usp=email )
Change subject: drivers/usb/intel_bluetooth: Fix GBTE to return Local0 ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84989/comment/56981efb_25bebd00?usp... : PS1, Line 7: Fix GBTE return value
Maybe extend: […]
Done
https://review.coreboot.org/c/coreboot/+/84989/comment/aa3ac5c4_3c3c0229?usp... : PS1, Line 9: `acpigen_soc_get_tx_gpio` will put the result into LOCAL0, rather than
nit: Local0
Done
https://review.coreboot.org/c/coreboot/+/84989/comment/88156f59_824524ef?usp... : PS1, Line 11:
Add the value before and after, and describe, if something starts working now?
Done
File src/drivers/usb/acpi/intel_bluetooth.c:
https://review.coreboot.org/c/coreboot/+/84989/comment/71adb0ed_dd2c0e7e?usp... : PS1, Line 329:
This is not needed as you use `acpigen_write_return_*` instead.
Done