Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34459 )
Change subject: [WIP]payloads/tianocore: Enable UEFIPayload
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
I recall reading that the UEFIPayload package failed to boot with coreboot, so I would like this to be boot-tested.
https://review.coreboot.org/c/coreboot/+/34459/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34459/1//COMMIT_MSG@13
PS1, Line 13: TEST=Able to build with tianocore debug and release build.
What about boot-testing tianocore? I don't think build-testing is enough testing for this change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b7785fde9f4113b2cd91323ac0358b229c5a6e6
Gerrit-Change-Number: 34459
Gerrit-PatchSet: 1
Gerrit-Owner: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 21 Jul 2019 01:07:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment