Attention is currently required from: Nick Vaccaro, Paul Menzel, Shawn Ku, Subrata Banik.
Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79173?usp=email )
Change subject: mb/google/nissa/var/quandiso: Disable un-used C1 port by daughterboard
......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79173/comment/a8ea4fd7_5b4be9a5 :
PS6, Line 9: disabled
“to” requires infinitive here: disable
Done
https://review.coreboot.org/c/coreboot/+/79173/comment/ed71a8eb_9b11f0be :
PS6, Line 10: that C1 port is not present
without a C1 port.
Done
https://review.coreboot.org/c/coreboot/+/79173/comment/224b02f4_93c01fcd :
PS6, Line 10: wqnew
new?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79173?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6f702f60c772176e80b3452bf957d10625564102
Gerrit-Change-Number: 79173
Gerrit-PatchSet: 7
Gerrit-Owner: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shawn Ku
shawnku@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shawn Ku
shawnku@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Wed, 22 Nov 2023 11:26:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment