Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33738 )
Change subject: soc/intel/icelake: Add ENABLE_DISPLAY_OVER_EXT_PCIE_GFX kconfig ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33738/12/src/soc/intel/icelake/Kcon... File src/soc/intel/icelake/Kconfig:
https://review.coreboot.org/c/coreboot/+/33738/12/src/soc/intel/icelake/Kcon... PS12, Line 210: select ALWAYS_LOAD_OPROM
I am really sorry for getting back to this. […]
i guess ALWAYS_LOAD_OPROM is very justified name to tell user that it will always load oprom without bothering if user would like to execute it or not.
and its choice of mainboard user to make a board design with oprom enable card/internal device to load that specifically. I don't think ALWAYS_LOAD_OPROM need a better name :)
only one thing might be in question, do we really need an another Kconfig ENABLE_DISPLAY_OVER_EXT_PCIE_GFX when its just matter of selecting ALWAYS_LOAD_OPROM, i believe answer would be, it might provide a better context for mainboard user to really know what we are doing or what we intended to do by selecting ENABLE_DISPLAY_OVER_EXT_PCIE_GFX config delicately