Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36385 )
Change subject: ec/lenovo/h8: Add a config to indicate whether dock init is needed ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36385/1/src/ec/lenovo/h8/Kconfig File src/ec/lenovo/h8/Kconfig:
https://review.coreboot.org/c/coreboot/+/36385/1/src/ec/lenovo/h8/Kconfig@47 PS1, Line 47: H8_NEED_DOCK_INIT Maybe it's not worth to overcomplicate things. What about H8_DOCK_INIT and H8_EARLY_DOCK_INIT and make them mutually exclusive in Kconfig (depend !...)
https://review.coreboot.org/c/coreboot/+/36385/1/src/ec/lenovo/h8/Kconfig@48 PS1, Line 48: "Dock init during boot is necessary" This is a property of the board. Please don't make it user selectable.