Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36342 )
Change subject: sb/intel/common/spi: Add Baytrail/Braswell support ......................................................................
Patch Set 5: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/36342/5/src/southbridge/intel/commo... File src/southbridge/intel/common/spi.h:
https://review.coreboot.org/c/coreboot/+/36342/5/src/southbridge/intel/commo... PS5, Line 46: CONFIG(SOC_INTEL_BRASWELL)) Alternatively, we could add Kconfig flags and select them from each chipset.
https://review.coreboot.org/c/coreboot/+/36342/5/src/southbridge/intel/commo... File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/c/coreboot/+/36342/5/src/southbridge/intel/commo... PS5, Line 38: #endif Wouldn't be necessary if using Kconfig for the flags.