Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37283 )
Change subject: soc/intel/common/block/cse: Modify handling of HMRFPO_ENABLE command
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37283/4/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/37283/4/src/soc/intel/common/block/...
PS4, Line 682: printk(BIOS_ERR, "HECI: Enable Failed, resp status:%d\n", resp.status);
Please add a space after the colon. Please add a more elaborate the error message, so a user knows about the effects.
HECI: Enable failed (response status: %d), you won’t be able to …\n
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37283
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c87998fa105947e5ba4638a8e68625e46703448
Gerrit-Change-Number: 37283
Gerrit-PatchSet: 4
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 10 Dec 2019 10:25:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment