EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48069 )
Change subject: mb/google/brya: Enable ACPI and add ACPI table ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48069/3/src/mainboard/google/brya/m... File src/mainboard/google/brya/mainboard.c:
https://review.coreboot.org/c/coreboot/+/48069/3/src/mainboard/google/brya/m... PS3, Line 16: static unsigned long mainboard_write_acpi_tables( : const struct device *device, unsigned long current, acpi_rsdp_t *rsdp) : { : return current; : }
I think we can skip this function for now. […]
hmm, so keep this or remove this?
https://review.coreboot.org/c/coreboot/+/48069/3/src/mainboard/google/brya/m... PS3, Line 25: dev->ops->acpi_inject_dsdt = chromeos_dsdt_generator;
should this go in CB:48111?
okay, let me change this.