Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34137 )
Change subject: soc/intel/common/lpss: Add function to check for a LPSS controller ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34137/12/src/soc/intel/common/block... File src/soc/intel/common/block/lpss/lpss.c:
https://review.coreboot.org/c/coreboot/+/34137/12/src/soc/intel/common/block... PS12, Line 50: __weak const pci_devfn_t *soc_lpss_controllers_list(size_t *size) : { : *size = 0; : return NULL; : }
Compilation does not fail on removing this. This would serve more as indicator that the SOC needs to provide the list or else the is_dev_lpss would always return false.
I don't understand what you mean by "indicator that the SOC needs to provide the list or else the is_dev_lpss would always return false."
If is_dev_lpss gets included in the image, it will fail linking if soc_lpss_controllers_list() is not provided by the SoC. The way it is done right now will return false always. Isn't a build time failure better indication that SoC implementation should be provided?