1 comment:
File src/soc/intel/common/block/lpss/lpss.c:
__weak const pci_devfn_t *soc_lpss_controllers_list(size_t *size)
{
*size = 0;
return NULL;
}
Compilation does not fail on removing this. This would serve more as indicator that the SOC needs to provide the list or else the is_dev_lpss would always return false.
I don't understand what you mean by "indicator that the SOC needs to provide the list or else the is_dev_lpss would always return false."
If is_dev_lpss gets included in the image, it will fail linking if soc_lpss_controllers_list() is not provided by the SoC. The way it is done right now will return false always. Isn't a build time failure better indication that SoC implementation should be provided?
To view, visit change 34137. To unsubscribe, or for help writing mail filters, visit settings.