Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37660 )
Change subject: ifwitool: Introduce a skip BPDT parameter ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/37660/1/util/cbfstool/ifwitool.c File util/cbfstool/ifwitool.c:
https://review.coreboot.org/c/coreboot/+/37660/1/util/cbfstool/ifwitool.c@23 PS1, Line 23: #define max(a, b) (((a) > (b)) ? (a) : (b)) As we do have access to commonlib would you consider using commonlib/helpers.h and the MAX macro from there? Or is there a real need to repeat it here again?
https://review.coreboot.org/c/coreboot/+/37660/1/util/cbfstool/ifwitool.c@19... PS1, Line 1904: NB What does NB stand for, number?