Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32773 )
Change subject: coreboot: add post code for memory error from FSP ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32773/2/src/drivers/intel/fsp1_1/raminit.c File src/drivers/intel/fsp1_1/raminit.c:
https://review.coreboot.org/#/c/32773/2/src/drivers/intel/fsp1_1/raminit.c@2... PS2, Line 201: post_code(POST_INVALID_FSP); : die("ERROR - HOB pointer is NULL!\n"); Unrelated to your change, but shouldn't this check be outside of the config check? We use hob_list_ptr again on line 297.
If it were only used in the section displaying the hobs, we shouldn't be killing the system just because we can't print out the information. Yeah, it's probably a symptom of a larger problem, but we should run as long as we can.