Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35233 )
Change subject: intel/fsp2_0: Move temporary RAM to .bss with FSP_USES_CB_STACK ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35233/1/src/drivers/intel/fsp2_0/me... File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/c/coreboot/+/35233/1/src/drivers/intel/fsp2_0/me... PS1, Line 37: 0x20000 I think it would be best to have a config option that can be provided by SoC to determine the size of the temp ram. It should ideally match integration guide for that platform.
https://review.coreboot.org/c/coreboot/+/35233/1/src/soc/intel/cannonlake/Kc... File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/35233/1/src/soc/intel/cannonlake/Kc... PS1, Line 122: 0x20000 I believe we would still need a larger stack with FSP_USES_CB_STACK. I have posted a question on CB:35165 to understand the size requirement for stack.