4 Sep
2020
4 Sep
'20
2:48 a.m.
Andy Yeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42205 )
Change subject: mb/google/dedede: Add ACPI support for camera in WDee ......................................................................
Patch Set 17: Code-Review-1
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/42205/17/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42205/17/src/mainboard/google/deded... PS17, Line 118: device pci 15.3 on # I2C 3 Why there is no NVM i2c device defined?
--
To view, visit https://review.coreboot.org/c/coreboot/+/42205
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f6b490832d2c34c86512384eb7470f13a212a66
Gerrit-Change-Number: 42205
Gerrit-PatchSet: 17
Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Andy Yeh
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Kaiyen Chang kaiyen.chang@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar ronak.kanabar@intel.com
Gerrit-Reviewer: ShawnX Tu shawnx.tu@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Matt Delco delco@chromium.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Ren Kuo ren.kuo@quanta.corp-partner.google.com
Gerrit-CC: Sugnan Prabhu S sugnan.prabhu.s@intel.com
Gerrit-Comment-Date: Fri, 04 Sep 2020 09:48:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment