Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42802 )
Change subject: sb/intel: Fix bad uses of `find_resource` ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42802/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42802/3//COMMIT_MSG@12 PS3, Line 12: with `probe_resource` instead.
Why not just remove the NULL checking and let things die? Many of those cases seem like the resource […]
It's unlikely to ever run into the case where no resource is assigned, so I don't have a strong opinion about that.
If you want an always booting platform, you'd rather not use find_resource. On a QA system you likely want to die as boot failures are easy to spot.
Maybe we can keep using probe_resource() and NULL checks for general code usage, but add a Kconfig to die if a resource isn't found.