Hello HAOUAS Elyes, Angel Pons, Julius Werner, David Hendricks, Paul Menzel, build bot (Jenkins), Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34297
to look at the new patch set (#6).
Change subject: src: Make implicit fall throughs explicit ......................................................................
src: Make implicit fall throughs explicit
Implicit fall throughs are a perpetual source of bugs and Coverity Scan issues, so let's squash them once and for all. GCC can flag implicit fall throughs using the -Wimplicit-fallthrough warning, and this should ensure no more enter the code base. However, many fall throughs are intentional, and we can use the following comment style to have GCC suppress the warning.
switch (x) { case 1: y += 1; /* fall through */ case 2: y += 2; /* fall through - but this time with an explanation */ default: y += 3; }
This patch adds comments for all remaining intentional fall throughs, and tweaks some existing fall through comments to fit the syntax that GCC expects.
Change-Id: I1d75637a434a955a58d166ad203e49620d7395ed Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M src/console/vtxprintf.c M src/lib/edid.c M src/soc/nvidia/tegra124/sor.c M src/soc/rockchip/rk3288/sdram.c M src/southbridge/amd/agesa/hudson/hudson.c M src/southbridge/amd/cimx/sb800/lpc.c M src/southbridge/amd/cimx/sb900/lpc.c M src/southbridge/amd/sb700/lpc.c M src/southbridge/amd/sb800/lpc.c M src/vendorcode/amd/agesa/f12/Proc/CPU/S3.c M src/vendorcode/amd/agesa/f12/Proc/Mem/Main/muc.c M src/vendorcode/amd/agesa/f12/Proc/Mem/NB/mnphy.c M src/vendorcode/amd/agesa/f14/Proc/CPU/S3.c M src/vendorcode/amd/agesa/f14/Proc/Mem/Main/muc.c M src/vendorcode/amd/agesa/f14/Proc/Mem/NB/mnphy.c M src/vendorcode/amd/agesa/f15tn/Proc/CPU/S3.c M src/vendorcode/amd/agesa/f15tn/Proc/IDS/Debug/IdsDebugPrint.c M src/vendorcode/amd/agesa/f15tn/Proc/Mem/Main/muc.c M src/vendorcode/amd/agesa/f15tn/Proc/Mem/NB/mnphy.c M src/vendorcode/amd/agesa/f16kb/Proc/CPU/Family/0x16/KB/F16KbUtilities.c M src/vendorcode/amd/agesa/f16kb/Proc/CPU/S3.c M src/vendorcode/amd/agesa/f16kb/Proc/IDS/Debug/IdsDebugPrint.c M src/vendorcode/amd/agesa/f16kb/Proc/Mem/Main/muc.c M src/vendorcode/amd/agesa/f16kb/Proc/Mem/NB/mnphy.c 24 files changed, 107 insertions(+), 113 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/34297/6