Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46112 )
Change subject: soc/amd/picasso: Refactor workbuf check into separate function ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46112/1/src/soc/amd/picasso/bootblo... File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/46112/1/src/soc/amd/picasso/bootblo... PS1, Line 115: : #if CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK) I'm not crazy about this, but there are things that aren't defined if VBOOT_STARTS_BEFORE_BOOTBLOCK isn't being used. 1) _vboot2_work is only define if VBOOT of some sort is being used. 2) CMOS_RECOVERY_BYTE is defined from a config option that depends on VBOOT_STARTS_BEFORE_BOOTBLOCK.
In the next patch, the transfer block is also only defined if VBOOT is being used.
If desired, I can refactor to change all of this, but I'm not sure how valuable it really is.