build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39847 )
Change subject: soc/intel/tigerlake: Add support to initialize Memory ......................................................................
Patch Set 18:
(7 comments)
https://review.coreboot.org/c/coreboot/+/39847/18/src/soc/intel/tigerlake/me... File src/soc/intel/tigerlake/meminit_tgl.c:
https://review.coreboot.org/c/coreboot/+/39847/18/src/soc/intel/tigerlake/me... PS18, Line 320: else else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/39847/18/src/soc/intel/tigerlake/me... PS18, Line 321: printk(BIOS_INFO,"Undefined memory topology on Channel 0"); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39847/18/src/soc/intel/tigerlake/me... PS18, Line 329: else if ((info->topology == MEMORY_DOWN)) { Unnecessary parentheses - maybe == should be = ?
https://review.coreboot.org/c/coreboot/+/39847/18/src/soc/intel/tigerlake/me... PS18, Line 333: else if ((info->topology == SODIMM) || (info->topology == MIXED)) { else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/39847/18/src/soc/intel/tigerlake/me... PS18, Line 337: else Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/39847/18/src/soc/intel/tigerlake/me... PS18, Line 340: else Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/39847/18/src/soc/intel/tigerlake/me... PS18, Line 417: else { Statements should start on a tabstop