Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34900 )
Change subject: soc/intel/cnl: Add provision to configure SD controller write protect pin
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34900/2/src/soc/intel/cannonlake/ch...
File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/c/coreboot/+/34900/2/src/soc/intel/cannonlake/ch...
PS2, Line 189: Enable/disable SD Card Write Protect Pin
Enable/disable SD Card Write Protect Pin Configuration? Also, mention that this is only for CML?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34900
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1736a2ec4b9370d23a8e3349603eb363e6f59b9
Gerrit-Change-Number: 34900
Gerrit-PatchSet: 2
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 16 Aug 2019 15:01:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment