Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36463 )
Change subject: soc/intel/{IA-CPU/SOC}: Move sleepstates.asl into southbridge/intel/common/acpi
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36463/4/src/southbridge/intel/commo...
File src/southbridge/intel/common/acpi/sleepstates.asl:
https://review.coreboot.org/c/coreboot/+/36463/4/src/southbridge/intel/commo...
PS4, Line 9: , or
: * (at your option) any later version.
Well, when there is nothing copyrightable here (full ACK), why not remove the whole header like it's done for config and devicetree files?
Coreboot lint check blocks that (iirc) and I don't think there is a linter out that that is smart enough to figure out if code is sufficiently original to be considered an original work, so it's fine just keeping it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36463
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie2132189f91211df74f8b5546da63ded4fdf687a
Gerrit-Change-Number: 36463
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 31 Oct 2019 11:26:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment