[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8192: devapc: add basic devapc drivers

[Yidi Lin (Code Review)]

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46402 )

Change subject: soc/mediatek/mt8192: devapc: add basic devapc drivers
......................................................................

Patch Set 48:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46402/46/src/soc/mediatek/mt8192/in... 
File src/soc/mediatek/mt8192/include/soc/devapc.h:

https://review.coreboot.org/c/coreboot/+/46402/46/src/soc/mediatek/mt8192/in... 
PS46, Line 20: #define AO_APC_CON (devapc_ao_base + (unsigned long)OFF_AO_APC_CON)
             : #define MAS_SEC    (devapc_ao_base + (unsigned long)OFF_MAS_SEC_0)
             : #define MAS_DOM_0  (devapc_ao_base + (unsigned long)OFF_MAS_DOM_0)
             : #define MAS_DOM_1  (devapc_ao_base + (unsigned long)OFF_MAS_DOM_1)
> I think this coding style (have define in header that uses some static variable inside c, and didn't […]

Done