[coreboot-gerrit] Change in ...coreboot[master]: drivers/apple: Add hybrid graphics driver

[Evgeny Zinoviev (Code Review)]

Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32719 )

Change subject: drivers/apple: Add hybrid graphics driver
......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/#/c/32719/7/src/drivers/apple/hybrid_graphics/hy... 
File src/drivers/apple/hybrid_graphics/hybrid_graphics.c:

https://review.coreboot.org/#/c/32719/7/src/drivers/apple/hybrid_graphics/hy... 
PS7, Line 35: 	config = dev->chip_info;
> just check for dev->chip_info directly

ok

https://review.coreboot.org/#/c/32719/7/src/drivers/apple/hybrid_graphics/hy... 
PS7, Line 37: 		printk(BIOS_INFO, "Hybrid graphics: Not installed\n");
> that should probably BIOS_ERR, as this is a miss configuration

agreed. but it is BIOS_DEBUG in lenovo/hybrid_graphics in the same place, I was a bit surprised and made it BIOS_INFO :)