Attention is currently required from: Peter Stuge, Martin Roth, ron minnich.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70158 )
Change subject: coreboot_tables: Make existing alignment conventions more explicit
......................................................................
Patch Set 3:
(2 comments)
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/70158/comment/b951ef2a_58f7c960
PS2, Line 80: assert(IS_ALIGNED(rec->size, LB_ENTRY_ALIGN));
I do not want an assumption in the code that must hold true on other compilers and archs to avoid […]
Any more concerns here or can we land this?
https://review.coreboot.org/c/coreboot/+/70158/comment/e904018e_549abeda
PS2, Line 306: strlen(mainboard_part_number) + 1, LB_ENTRY_ALIGN);
Yes, because 4 should be good enough here. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70158
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaeef29ef255047a855066469e03b5481812e5975
Gerrit-Change-Number: 70158
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Peter Stuge
peter@stuge.se
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Attention: Peter Stuge
peter@stuge.se
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Wed, 21 Dec 2022 17:33:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Stuge
peter@stuge.se
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment