Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56810 )
Change subject: [TESTME] soc/amd/common/block/gpio_banks: add remote GPIO support ......................................................................
Patch Set 3:
(2 comments)
File src/soc/amd/common/block/gpio_banks/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127450): https://review.coreboot.org/c/coreboot/+/56810/comment/17ee399a_afefde21 PS3, Line 21: if (SOC_GPIO_TOTAL_PINS < AMD_GPIO_FIRST_REMOTE_GPIO_NUMBER || Comparisons should place the constant on the right side of the test
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127450): https://review.coreboot.org/c/coreboot/+/56810/comment/43bcd093_9929a3fd PS3, Line 43: if (SOC_GPIO_TOTAL_PINS < AMD_GPIO_FIRST_REMOTE_GPIO_NUMBER || Comparisons should place the constant on the right side of the test