Attention is currently required from: Nico Huber, Duncan Laurie, Tim Wawrzynczak.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52737 )
Change subject: libpayload: i8042: Enable keyboard translation by defualt on exit
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Would need to just use CHROMEOS since this is inside libpayload kconfig, but that could certainly wo […]
Based on the discussion on CB:47594, it looks like it is safe to set the default to set2+translate. So, going with a default of 'y' seems fine to me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52737
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25dfe3f425a5bb57e97476564886672b707aa3bd
Gerrit-Change-Number: 52737
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie
duncan@iceblink.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Duncan Laurie
duncan@iceblink.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 28 Apr 2021 21:15:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Duncan Laurie
duncan@iceblink.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment