[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: add memory configuration support

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38606 )

Change subject: soc/intel/tigerlake: add memory configuration support
......................................................................

Patch Set 13:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38606/8/src/soc/intel/tigerlake/inc... 
File src/soc/intel/tigerlake/include/soc/meminit_tgl.h:

https://review.coreboot.org/c/coreboot/+/38606/8/src/soc/intel/tigerlake/inc... 
PS8, Line 26: lpddr4x_
> I added "lpddr4x" because we dropped READ_SMBUS from this list, but I wasn't sure if it could potent […]

Even if READ_SMBUS is dropped, I think we can still keep this as spd_read_type. In the future, once we add support for more memory types, we can potentially reuse the same enum. I think we can always add READ_SMBUS back at that point.

https://review.coreboot.org/c/coreboot/+/38606/8/src/soc/intel/tigerlake/inc... 
PS8, Line 32: lpddr4x_
> Given comment above, should I drop the lpddr4x in both of these structure names?

Yes, I think spd_info can be used by any memory type.