build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32789 )
Change subject: soc/intel/icelake: Make use of gpio_pm_configure()
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/#/c/32789/8/src/soc/intel/icelake/chip.h
File src/soc/intel/icelake/chip.h:
https://review.coreboot.org/#/c/32789/8/src/soc/intel/icelake/chip.h@273
PS8, Line 273: uint8_t gpio_override_pm;
code indent should use tabs where possible
https://review.coreboot.org/#/c/32789/8/src/soc/intel/icelake/chip.h@273
PS8, Line 273: uint8_t gpio_override_pm;
please, no spaces at the start of a line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32789
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic30a490aadb8cc9c05a19a05533ab0196c69b7f1
Gerrit-Change-Number: 32789
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 16 May 2019 16:58:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment