build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43796 )
Change subject: soc/mediatek/mt8183: Transfer ddr geometry type to dram blob ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43796/1/src/soc/mediatek/mt8183/mem... File src/soc/mediatek/mt8183/memory.c:
https://review.coreboot.org/c/coreboot/+/43796/1/src/soc/mediatek/mt8183/mem... PS1, Line 102: const struct sdram_params * sdram_cfg = get_sdram_config(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43796/1/src/soc/mediatek/mt8183/mem... PS1, Line 102: const struct sdram_params * sdram_cfg = get_sdram_config(); "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/43796/1/src/soc/mediatek/mt8183/mem... PS1, Line 115: dparam->freq_params[0].ddr_geometry = sdram_cfg->ddr_geometry; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43796/1/src/soc/mediatek/mt8183/mem... PS1, Line 116: printk(BIOS_INFO, "ddr_geometry:%d\n", sdram_cfg->ddr_geometry); please, no spaces at the start of a line