Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43378 )
Change subject: soc/intel/skylake: Move `acpi_fill_fadt` to fadt.c
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43378/1/src/soc/intel/skylake/fadt....
File src/soc/intel/skylake/fadt.c:
https://review.coreboot.org/c/coreboot/+/43378/1/src/soc/intel/skylake/fadt....
PS1, Line 62: 1
use macro
Refer to the explanations I provided on CB:43372
https://review.coreboot.org/c/coreboot/+/43378/1/src/soc/intel/skylake/fadt....
PS1, Line 80: 0
use macro
Refer to the explanations I provided on CB:43372
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43378
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ecf3c0b0c822185ca66bae1bd65b0cf24512a49
Gerrit-Change-Number: 43378
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 12 Jul 2020 23:29:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment