Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37794 )
Change subject: soc/intel/cannonlake: Pass MISCCFG.bit 0-5 devicetree.cb to ASL
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37794/1/src/soc/intel/cannonlake/gp...
File src/soc/intel/cannonlake/gpio_common.c:
https://review.coreboot.org/c/coreboot/+/37794/1/src/soc/intel/cannonlake/gp...
PS1, Line 27: else
valid point, i guess my proposal would be don't bother about what FSP sets, we are independent in […]
Yes, i'm on it already for coming platform. to get rid that in FSP
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37794
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I75246be01aa4ab4cfa1e184ab6a11b718471995e
Gerrit-Change-Number: 37794
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 18 Dec 2019 05:15:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment