Mengqi Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32460 )
Change subject: mediatek/mt8183: Add SPI GPIO driving setting ......................................................................
Patch Set 9:
(4 comments)
https://review.coreboot.org/#/c/32460/9/src/soc/mediatek/mt8183/gpio.c File src/soc/mediatek/mt8183/gpio.c:
https://review.coreboot.org/#/c/32460/9/src/soc/mediatek/mt8183/gpio.c@136 PS9, Line 136: gpio_set_spi_driving
Is this a per-board design or per-soc logic? […]
This is a per-soc logic, it can be applied to all 8183.
https://review.coreboot.org/#/c/32460/9/src/soc/mediatek/mt8183/gpio.c@143 PS9, Line 143: ((milliamps >= 2) && (milliamps <= 16));
&& has lower precedence so you don't need to quote, i.e.. […]
OK, I will fix it.
https://review.coreboot.org/#/c/32460/9/src/soc/mediatek/mt8183/gpio.c@162 PS9, Line 162:
should we do some assert here if pad_select is something else?
If we need do this, I think it's better to put it to line144 with other assert together.
https://review.coreboot.org/#/c/32460/9/src/soc/mediatek/mt8183/gpio.c@181 PS9, Line 181: }
should we assert on any other values for bus?
I have do it at line142.