Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45878 )
Change subject: tigerlake mainboards: switch to devtree aliases for PMC MUX connectors
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45878/6/src/mainboard/google/voltee...
File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/45878/6/src/mainboard/google/voltee...
PS6, Line 23: dev->path.generic.id == 1;
You can also add an additional check to ensure that dev->chip_ops == drivers_intel_pmc_mux_conn_ops just in case we end up adding another generic non-PMC conn device.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45878
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib51764da5b3c029f9ac7ac60199a0aedfc7f29b1
Gerrit-Change-Number: 45878
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 27 Oct 2020 20:30:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment