EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46566 )
Change subject: mb/google/zork: Correct get board version and get fw config condition
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46566/3/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/baseboard/helpers.c:
https://review.coreboot.org/c/coreboot/+/46566/3/src/mainboard/google/zork/v...
PS3, Line 60: google_chromeec_cbi_get_fw_config(&known_value)
Sorry, I think I am missing something here. […]
This actual called cbi_get_unit32 like get_board_id so the same logic.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46566
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia49ac1ee35302f8f6afe8c0eb8e13afdf36c5b2b
Gerrit-Change-Number: 46566
Gerrit-PatchSet: 5
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 19 Oct 2020 19:07:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment