Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44416 )
Change subject: mb/intel/jasperlake_rvp: Configure GPIOs related to UFC
......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44416/2/src/mainboard/intel/jasperl...
File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c:
https://review.coreboot.org/c/coreboot/+/44416/2/src/mainboard/intel/jasperl...
PS2, Line 83: 0
shouldn't this be 1? or driver drivers it from PR0?
Drivers drives it
https://review.coreboot.org/c/coreboot/+/44416/2/src/mainboard/intel/jasperl...
PS2, Line 89: PLTRST
DEEP
Done
https://review.coreboot.org/c/coreboot/+/44416/2/src/mainboard/intel/jasperl...
PS2, Line 92: PLTRST
DEEP
Done
https://review.coreboot.org/c/coreboot/+/44416/2/src/mainboard/intel/jasperl...
PS2, Line 113: PLTRST
DEEP
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44416
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I026c16f73cf597614efaea3e0f0ab1e2cfe1e211
Gerrit-Change-Number: 44416
Gerrit-PatchSet: 3
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 14 Aug 2020 05:50:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Gerrit-MessageType: comment