Attention is currently required from: Raul Rangel, Julius Werner. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62506 )
Change subject: libpayload: cbmem_console: Drop loglevel markers from snapshot ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62506/comment/82b93ab1_ab3168da PS1, Line 9: recently CB:61308 for my own reference
File payloads/libpayload/drivers/cbmem_console.c:
https://review.coreboot.org/c/coreboot/+/62506/comment/39ba1777_769b23a6 PS1, Line 120: /* Slight memory corruption may occur between reboots and give us a few : unprintable characters like '\0'. Replace them with '?' on output. */ : for (cursor = 0; cursor < size; cursor++) : if (!isprint(console_c[cursor]) && !isspace(console_c[cursor])) : console_c[cursor] = '?'; Maybe we should just keep the non-printable characters, and let payloads decide how to deal with them. For that we'll need to add BIOS_LOG_IS_MARKER and friends to libpayload.h (will that cause licensing issue?). What do you think?