Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39178 )
Change subject: sb/amd: Move smbus to common place
......................................................................
Patch Set 7:
If you can, try to split this into two patches. Refer to CB:38206 and then CB:38036 as an example:
- CB:38206 does a simple-to-review (but a bit large) change that results in changes to the coreboot.rom
- CB:38036 is huge and much more complex, but there are no changes when building with BUILD_TIMELESS=1
This means that only the first change needs to be reviewed thoroughly and/or tested. The second change is purely cosmetic, so it's much easier to review :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39178
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifaa72540014dd53059a13db0875c9e11fefb1f4f
Gerrit-Change-Number: 39178
Gerrit-PatchSet: 7
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 01 Mar 2020 14:03:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment