Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47221 )
Change subject: mb/purism/librem_mini: Fix PCIe clock source mapping in devicetree
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47221/1/src/mainboard/purism/librem...
File src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/47221/1/src/mainboard/purism/librem...
PS1, Line 198: or module not detected
... […]
I don't understand this - if SRCCLKREQ2 isn't connected, then why does it only work when PcieClkSrcUsage[2] is set to free-run?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47221
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdaba51d971a39a6da6df82652b7420d7324dee5
Gerrit-Change-Number: 47221
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 05 Nov 2020 17:22:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment