Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35824 )
Change subject: arch/x86: Don't allow separate verstage to boot from romcc bootblock ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35824/1/src/arch/x86/bootblock_simp... File src/arch/x86/bootblock_simple.c:
https://review.coreboot.org/c/coreboot/+/35824/1/src/arch/x86/bootblock_simp... PS1, Line 30: #if CONFIG(VBOOT_SEPARATE_VERSTAGE)
Should we #error out here in this configuration? Or silently not honor the Kconfig? Or add the dependency in Kconfig?
VBOOT_SEPARATE_VERSTAGE depends on VBOOT_STARTS_IN_BOOTBLOCK which depends on C_ENVIRONMENT_BOOTBLOCK, so this is already taken care off.